Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the design and defaults #74

Merged
merged 19 commits into from
Sep 10, 2022
Merged

Conversation

abhi18av
Copy link
Member

@abhi18av abhi18av commented Aug 21, 2022

Hey there 👋

This Pull-request address important enhancements focusing on better usability and easier user interaction.

Main changes:

  • Promote QC to main workflow
  • Deprecate sra support (point to fetchngs)
  • Move default_params
  • Rename batch -> normal analysis
  • Add the custom container build mechanism
  • Standardize the deployment of Conda
  • Remove necessity of user dealing with GATK-jar when using docker or conda.

@Mxrcon
Copy link
Member

Mxrcon commented Sep 1, 2022

@abhi18av on my latest commits I tried to standardize the overall deployment of containers and conda environment as well. On conda step I added a step to register the GATK jar and check MTBseq installation.
I think that the overall goals of this Pull request will be addressed by this, so I'm Kindly requesting for a review.

I published the image here: https://github.com/orgs/mtb-bioinformatics/packages/container/package/mtbseq-nf, It's published as a mtb-bioinformatics package instead of mtbseq-nf package image, as It may be complex to explain that this image is required to run mtbseq-nf but isn't the mtbseq-nf tool containerized.

@Mxrcon Mxrcon marked this pull request as ready for review September 1, 2022 14:01
@Mxrcon Mxrcon self-assigned this Sep 1, 2022
@Mxrcon Mxrcon added the enhancement New feature or request label Sep 1, 2022
@Mxrcon Mxrcon linked an issue Sep 1, 2022 that may be closed by this pull request
@abhi18av
Copy link
Member Author

abhi18av commented Sep 3, 2022

@abhi18av
Copy link
Member Author

Merging this PR after local testing

@abhi18av abhi18av merged commit 84414fd into master Sep 10, 2022
@abhi18av abhi18av deleted the improve-analysis-name branch September 10, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider creating a custom container with all the necessary deps.
2 participants