fix: rename llama-sampling to llama-sampler in bootstrap.sh#290
Merged
jhen0409 merged 3 commits intomybigday:mainfrom Feb 11, 2026
Merged
Conversation
Upstream llama.cpp PR #19363 renamed llama-sampling.{h,cpp} to
llama-sampler.{h,cpp}. Update the bootstrap copy commands and
remove the old files to fix the sync-llama-cpp CI workflow.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update submodule to include the llama-sampling -> llama-sampler rename (PR #19363) so bootstrap.sh can find the new filenames. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updated cpp sources from llama.cpp b7988 via bootstrap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a-ghorbani
changed the title
Collaborator
Author
|
@jhen0409 This fixes the sync-llama-cpp CI failure (we were seeing in the actions). Ready for review, let me know if anything needs adjusting. |
jhen0409
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream llama.cpp PR #19363 renamed
src/llama-sampling.{h,cpp}tosrc/llama-sampler.{h,cpp}, which breaks the sync-llama-cpp CI workflow:This PR:
cpcommands inscripts/bootstrap.shto reference the new filenamescpp/llama-sampling.{h,cpp}files (would cause duplicate symbols since the build system uses glob patterns)No other changes needed —
cpp/llama-grammar.cppis copied from upstream and will pick up#include "llama-sampler.h"automatically, and CMakeLists/podspec use glob patterns.