Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add final where appropriate per open rewrite #2819

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[ci] Add final where appropriate per open rewrite #2819

merged 1 commit into from
Feb 20, 2023

Conversation

hazendaz
Copy link
Member

relaxed some of its suggestions but generally took most.

@hazendaz
[ci] Add final where appropriate per open rewrite
aa38fec 
relaxed some of its suggestions but generally took most.
@hazendaz hazendaz self-assigned this Feb 20, 2023
@hazendaz
Copy link
Member Author

rewrite had issues where multiple constructors involved where one satisfied for final but others did not. Those items were retained without final as per original code. The remainder were looked at to ensure they were in fact being set as final.

@coveralls
Copy link

Coverage Status

Coverage: 87.51%. Remained the same when pulling aa38fec on hazendaz:copyright into 105914b on mybatis:master.

@hazendaz hazendaz merged commit 4f04806 into mybatis:master Feb 20, 2023
@kazuki43zoo kazuki43zoo added the polishing Improve a implementation code or doc without change in current behavior/content label May 14, 2023
@kazuki43zoo kazuki43zoo added this to the 3.5.12 milestone May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hazendaz hazendaz

Labels
polishing Improve a implementation code or doc without change in current behavior/content
Projects
None yet
Milestone
3.5.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hazendaz @coveralls @kazuki43zoo