Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor id arguments don't need to be listed first #2548

Merged
merged 2 commits into from
May 14, 2022
Merged

Constructor id arguments don't need to be listed first #2548

merged 2 commits into from
May 14, 2022

Conversation

Condor70
Copy link

@Condor70 Condor70 commented May 5, 2022 •
edited
Loading

Fixes #2541

@Condor70 Condor70 marked this pull request as ready for review May 5, 2022 08:45
@Condor70 Condor70 changed the title Constructor id arguments don't need to be listed first #2541 Constructor id arguments don't need to be listed first May 5, 2022
harawata
harawata reviewed May 5, 2022
View reviewed changes
Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Condor70 !

Just one comment from me.

@kazuki43zoo ,
Feel free to comment.
I'm not familiar with this stuff very much.

src/main/java/org/apache/ibatis/builder/xml/mybatis-mapper.xsd Outdated Show resolved Hide resolved
@harawata harawata self-assigned this May 14, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 87.302% when pulling b891b5b on Condor70:master into 8c5474b on mybatis:master.

@harawata harawata merged commit 7b856e8 into mybatis:master May 14, 2022
@harawata
Copy link
Member

Thank you, @Condor70 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harawata harawata harawata left review comments

Assignees

@harawata harawata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constructor id arguments don't need to be listed first
3 participants
@Condor70 @coveralls @harawata