Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forObject is expecting an Object not its Class #2284

Merged
merged 1 commit into from
Jul 9, 2021
Merged

forObject is expecting an Object not its Class #2284

merged 1 commit into from
Jul 9, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jul 8, 2021

@zakkak zakkak force-pushed the fix-null-meta-object branch from dd45881 to 7e5e637 Compare July 8, 2021 16:58
@zakkak zakkak changed the title forObject is expecting an Object not it's Class forObject is expecting an Object not its Class Jul 8, 2021
@zakkak zakkak force-pushed the fix-null-meta-object branch from 7e5e637 to 500591c Compare July 8, 2021 17:02
@zakkak zakkak force-pushed the fix-null-meta-object branch from 500591c to 9466ddf Compare July 8, 2021 17:05
@zakkak zakkak mentioned this pull request Jul 8, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.258% when pulling 9466ddf on zakkak:fix-null-meta-object into 193e6fa on mybatis:master.

zhfeng
zhfeng approved these changes Jul 9, 2021
View reviewed changes
Copy link

@zhfeng zhfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and will be very helpful to the quarkus-mybatis extension. Thanks @zakkak

@harawata harawata added this to the 3.5.8 milestone Jul 9, 2021
@harawata harawata added the bug label Jul 9, 2021
@harawata harawata merged commit 033be14 into mybatis:master Jul 9, 2021
@harawata
Copy link
Member

harawata commented Jul 9, 2021 •
edited
Loading

Thank you, @zakkak and @zhfeng !
If possible, please verify the fix with the latest 3.5.8-SNAPSHOT.

@zhfeng
Copy link

zhfeng commented Jul 9, 2021

@harawata yeah, I'd verified it with the lastest mybatis in quarkus-mybatis and it works. Thanks !

@zhfeng zhfeng mentioned this pull request Jul 9, 2021
Merged
@zakkak zakkak deleted the fix-null-meta-object branch July 9, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhfeng zhfeng zhfeng approved these changes

Assignees

@harawata harawata

Labels
bug
Projects
None yet
Milestone
3.5.8
Development

Successfully merging this pull request may close these issues.

Investigate to remove the --report-unsupported-elements-at-runtime in native mode
4 participants
@zakkak @coveralls @harawata @zhfeng