Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB_VENDOR returns null when no properties is specified in XML config #3296

Closed
harawata opened this issue Nov 9, 2024 · 0 comments · Fixed by #3297
Closed

DB_VENDOR returns null when no properties is specified in XML config #3296

harawata opened this issue Nov 9, 2024 · 0 comments · Fixed by #3297
Assignees
@harawata
Labels
bug
Milestone
3.5.17

Comments

@harawata
Copy link
Member

harawata commented Nov 9, 2024

When no <property /> is specified, the DB_VENDOR implementation should return the database product name [1], however, it returns null instead.

<databaseIdProvider type="DB_VENDOR" />

[1] https://mybatis.org/mybatis-3/configuration.html#databaseidprovider
harawata added a commit to harawata/mybatis-3 that referenced this issue Nov 9, 2024
@harawata
VendorDatabaseIdProvider#getDatabaseId() should return product name…
dc249c1 
… when properties is empty

`XMLConfigBuilder#databaseIdProviderElement()` sets an empty `Properties` rather than `null`.

fixes mybatis#3296
@harawata harawata mentioned this issue Nov 9, 2024
Merged
@harawata harawata self-assigned this Nov 9, 2024
@harawata harawata added the bug label Nov 9, 2024
@harawata harawata added this to the 3.5.17 milestone Nov 9, 2024
@harawata harawata mentioned this issue Nov 9, 2024
Closed
@harawata harawata mentioned this issue Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harawata harawata

Labels
bug
Projects
None yet
Milestone
3.5.17
1 participant
@harawata