Skip to content

fix: report plugin version in hello JSON - #16

Merged
myagentdojo merged 1 commit into
mainfrom
codex/test-marketplace-auto-update
Aug 7, 2026
Merged

myagentdojo merged 1 commit into
mainfrom
codex/test-marketplace-auto-update

Conversation

@myagentdojo

@myagentdojo myagentdojo commented Aug 7, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Add pluginVersion to hello --json.
  • Bind the Bun compatibility adapter to canonical plugin metadata.
  • Require packaged distribution proof to preserve the version marker.

Why

The live marketplace auto-update acceptance needs a payload-owned signal that distinguishes the installed version. Marketplace metadata alone cannot prove that the harness selected and executed the refreshed payload.

Impact

Agents can read the executed plugin version directly from the offline JSON result. Existing fields and plain-text output remain unchanged.

Validation

  • bun run prove:all
  • 309 tests passed, 3 interactive/hosted cases skipped by contract
  • QuickJS and Bun output equivalent
  • Deterministic package proof passed
  • Native Claude and Codex install proof passed
  • Fallow: 0 introduced findings

Summary by CodeRabbit

  • New Features

    • The hello --json command now reports the installed plugin version alongside its command result, success status, and run ID.
    • Runtime execution automatically uses the configured plugin version when generating responses.
  • Bug Fixes

    • Improved packaged launcher validation to ensure reported plugin versions match the installed configuration.
  • Tests

    • Added coverage confirming successful JSON responses include accurate plugin version information.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f829ddc1-de96-43e0-b3bc-2f42a994b109

📥 Commits

Reviewing files that changed from the base of the PR and between 2c3370e and e6a5cc7.

📒 Files selected for processing (5)
  • plugin/runtime/hello-world.js
  • runtime/src/bun-proof-adapter.ts
  • runtime/src/portable-command.test.ts
  • runtime/src/portable-command.ts
  • scripts/prove-distribution.ts

📝 Walkthrough

Walkthrough

The runtime now loads the configured plugin version and exposes it to command execution. The hello --json response includes this version. Tests and distribution validation verify the reported value.

Changes

Plugin version reporting

Layer / File(s) Summary
Runtime version wiring
runtime/src/bun-proof-adapter.ts
The adapter loads plugin.config.json, assigns its version to globalThis.PLUGIN_VERSION, and dynamically imports executeCommand.
Hello response and validation
runtime/src/portable-command.ts, plugin/runtime/hello-world.js, runtime/src/portable-command.test.ts, scripts/prove-distribution.ts
The hello --json response includes pluginVersion. Tests and packaged-launcher validation check the configured version.
Estimated code review effort: 2 (Simple) ~10 minutes

Possibly related PRs

Suggested reviewers: nathanvale

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/test-marketplace-auto-update

Comment @coderabbitai help to get the list of available commands.

@myagentdojo
myagentdojo temporarily deployed to hosted-canary-qualification August 7, 2026 02:26 — with GitHub Actions Inactive
@myagentdojo
myagentdojo marked this pull request as ready for review August 7, 2026 02:33
@myagentdojo
myagentdojo merged commit 85ef9ec into main Aug 7, 2026
18 checks passed
@myagentdojo
myagentdojo deleted the codex/test-marketplace-auto-update branch August 7, 2026 02:33

This branch was previously deployed

1 inactive deployment
hosted-canary-qualification — e6a5cc7e Deployed Aug 7, 2026 by myagentdojo via Qualify immutable hosted candidates #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants