fix: bootstrap trusted canary driver - #2
Merged
Merged
Conversation
myagentdojo
had a problem deploying
to
hosted-canary-qualification
August 10, 2026 11:30 — with
GitHub Actions
Failure
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe canary flow now validates candidate targets against trusted configuration, supports protected template bootstrap, uses resolved targets during preflight, and passes the pull request head repository through the hosted workflow. ChangesTrusted Canary Qualification
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant HostedWorkflow
participant Qualification
participant CandidateConfigLoader
participant TrustedCanaryTargets
participant Transport
HostedWorkflow->>Qualification: pass CANARY_HEAD_REPOSITORY
Qualification->>CandidateConfigLoader: load candidate metadata
CandidateConfigLoader-->>Qualification: template, repository, and canary configuration
Qualification->>TrustedCanaryTargets: validate candidate targets
TrustedCanaryTargets-->>Qualification: resolved targets or canary_target_mismatch
Qualification->>Transport: bind identity and construct targets
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
@codex review |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imports the reviewed first-consumer bootstrap fix from
agent-plugin-templateinto the playground's trusted base. This leavesplugin.config.jsonunchanged withtemplate: true, then lets the follow-on initialization PR qualify the playground's exact same-repository canary targets.This is the bounded bootstrap step before PR #1. Its own hosted canary may remain red because the trusted base predates this exception and the playground credential cannot access the template's shared canary repositories.
Validation
bun test: 648 passed, 3 intentional skips, 0 failedbun test scripts/ship-canary.test.ts --coverage: 44 passed, 0 failedbun run build: passedbun run release:validate: passedbun run generate:check: currentagent-plugin-template#36Related: myagentdojo/agent-plugin-template#36
Related: #1
Summary by CodeRabbit
Bug Fixes
Tests