Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use urlquote to allow passwords with special characters. #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

espoirMur
Copy link

This change introduces the usage of urlquote to allow the use of passwords with special characters such as @.

Previously those characters were converted, changing the password and leat to authentication failures.

@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 218f960e-2f76-429e-aa73-367d2e11b48e

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/utils/setup_database.py 1 3 33.33%
Totals Coverage Status
Change from base Build 1f9efb3c-a791-4498-b745-263362a8011e: 0.1%
Covered Lines: 3470
Relevant Lines: 4041

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants