rewrite: empty notification Godind/issue317 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of notification Service, Menu and related service dependency.
Fixes empty menu notification. Reduced service dependency.
Now uses SK state and method notification properties and publishes notifications updates to SK instead of using a local notifiaction management system. This increases KIP/SK integration.
KIP now requires SK Alarm Silencer plugin to clear and silence alar - required to update notifications.
Issue: Zones also use a local service and so Zones notifications cannot be silenced or cleared until Zones are rebuilt to use ZK integrated Zones.