Skip to content

Commit

Permalink
Addresses PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jaredjensen committed Aug 3, 2024
1 parent d79e072 commit 3d904a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@
<mat-option value="capacity">Capacity</mat-option>
</mat-select>
</mat-form-field>
<mat-form-field formGroupName="gauge" class="options-grid-span2">
<mat-label>Highlights Width</mat-label>
<input type="number" min="0" max="25" matInput placeholder="Enter or select number..." name="highlightsWidth" formControlName="highlightsWidth" required>
</mat-form-field>
}
}

Expand All @@ -185,6 +181,9 @@
<mat-option value="horizontal">Horizontal</mat-option>
</mat-select>
</mat-form-field>
}

@if ( (widgetConfig.gauge?.type == 'ngRadial' && ['measuring','capacity'].indexOf(formMaster.value.gauge.subType)) || widgetConfig.gauge?.type == 'ngLinear') {
<mat-form-field formGroupName="gauge" class="options-grid-span2">
<mat-label>Highlights Width</mat-label>
<input type="number" min="0" max="25" matInput placeholder="Enter or select number..." name="highlightsWidth" formControlName="highlightsWidth" required>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export class WidgetGaugeNgLinearComponent extends BaseWidgetComponent implements
}

ngOnInit() {
this.initWidget();
this.setGaugeConfig();

const gaugeSize = this.wrapper.nativeElement.getBoundingClientRect();
Expand Down Expand Up @@ -130,8 +131,6 @@ export class WidgetGaugeNgLinearComponent extends BaseWidgetComponent implements
}
});

this.initWidget();

this.metaSub = this.zones$.subscribe(zones => {
if (zones && zones.length > 0) {
this.setHighlights(zones);
Expand Down

0 comments on commit 3d904a3

Please sign in to comment.