Adding support for S3 prefix #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably need to check a few more things in generated xml |
dmitry-mukhin
commented
Mar 2, 2023
Comment on lines
+29
to
+31
| # If you use prefix, you may need to add a path to `server.hostname` setting | ||
| # e.g. https://example-bucket-name.s3.us-west-2.amazonaws.com/example/prefix/ | ||
| prefix = "example/prefix" |
There was a problem hiding this comment.
I decided against adding logic to XML URL building at least at this stage.
mxpv
reviewed
Mar 8, 2023
dmitry-mukhin
requested review from
mxpv and
Contextualist
and removed request for
Contextualist and
mxpv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt on adding prefix support for S3-like storages
I'm not a go person, let me know if something is way off or need improvements.