Add server bind option #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from remote master
…rver handle path and Bind Address.
mxpv
reviewed
Oct 22, 2020
cmd/podsync/server.go
Outdated
| srv.Addr = fmt.Sprintf(":%d", port) | ||
| log.Debugf("using address: %s", srv.Addr) | ||
| srv.Addr = fmt.Sprintf("%s:%d", bindAddress, port) | ||
| //srv.Addr = fmt.Sprintf("{{$bindAddress:$port}}") |
There was a problem hiding this comment.
OK ,my bad miss that
| # Bind a specific IP addresses for server ,"*": bind all IP addresses which is default option, localhost or 127.0.0.1 bind a single IPv4 address | ||
| bind_address = "172.20.10.2" | ||
| # Specify path for reverse proxy and only [A-Za-z0-9] | ||
| path = "test" |
There was a problem hiding this comment.
Could you please update the comment that this is related to URL path specifically? Possibly with en example.
(I was confused for a moment why we need both path and data_dir until I referred to Go's documentation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Server.path and Server.bindAddress two options to special http server handle path and Bind Address.