Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelfUpdate for youtube-dl #119 #130

Merged
merged 3 commits into from
Apr 19, 2020
Merged

SelfUpdate for youtube-dl #119 #130

merged 3 commits into from
Apr 19, 2020

Conversation

Rpsl
Copy link
Contributor

@Rpsl Rpsl commented Apr 19, 2020

In the right way we need make update by cron with lock and stop downloader goroutines.

I can't do it at the moment, but i think we can call selfupdate on start.
Until selfupdate by timer not implemented we can fix it by stop and start again 🤷‍♂️

@dop251
Copy link
Contributor

dop251 commented Apr 19, 2020

I think this should be made optional in case there is an alternative update mechanism. It may be hard to believe but not everyone uses docker these days :)

@Rpsl
Copy link
Contributor Author

Rpsl commented Apr 19, 2020

@dop251 yep. you right.
when i was make that i don't think about not docker version and possible permission troubles.

at now i think selfupdate and any another version management must be outside application logic. for self i use that bash script in cron

#!/bin/sh

if [  "$(docker ps -a | grep podsync)" ]; then
	docker exec podsync  youtube-dl --update --verbose
fi

@Rpsl
Copy link
Contributor Author

Rpsl commented Apr 19, 2020

i revert code, but has left changes in dockerfile

mxpv added a commit that referenced this pull request Apr 19, 2020
@mxpv
Copy link
Owner

mxpv commented Apr 19, 2020

I've added optional flag to enable youtube-dl self updated.

@mxpv mxpv merged commit eb17568 into mxpv:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants