Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve youtube-dl logging #121

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Improve youtube-dl logging #121

merged 1 commit into from
Apr 16, 2020

Conversation

dop251
Copy link
Contributor

@dop251 dop251 commented Apr 16, 2020

When trying to deploy podsync on a DigitalOcean droplet, I faced with this error:

youtube-dl error: /tmp/podsync-119127838/17gpOMhVlas.%(ext)s error="failed to execute youtube-dl: exit status 1"

There was nothing more in the log that would allow to diagnose the problem further which was not very helpful. This PR makes it a bit easier by explicitly logging a message if a '429 Too Many Requests' error was detected or otherwise dumping the stdout from the youtube-dl command.

(Side note in case someone finds this by googling the error: turns out that due to DO's unique IPv6 allocation policy the /64 block ends up being shared by multiple droplets. Most likely Google considers a /64 block as one user (as it should be) and applies combined rate limits to it. The remedy here is to force IPv4).

cmd/podsync/updater.go Outdated Show resolved Hide resolved
@mxpv
Copy link
Owner

mxpv commented Apr 16, 2020

(Side note in case someone finds this by googling the error: turns out that due to DO's unique IPv6 allocation policy the /64 block ends up being shared by multiple droplets. Most likely Google considers a /64 block as one user (as it should be) and applies combined rate limits to it. The remedy here is to force IPv4).

Thanks, that's good to know. I think i'll start building FAQ for things like this.

…se of another error log the output from youtube-dl.
@mxpv
Copy link
Owner

mxpv commented Apr 16, 2020

Thanks!

@mxpv mxpv merged commit 174557e into mxpv:master Apr 16, 2020
@dop251 dop251 deleted the yt-dl-log branch April 16, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants