Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configurations and dependencies #22

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Update configurations and dependencies #22

merged 1 commit into from
Sep 21, 2022

Conversation

mattnichols
Copy link
Collaborator

@mattnichols mattnichols commented Sep 20, 2022 •
edited
Loading

Summary of Changes

  • Remove deprecated PMD rules
  • Add Hush plugin
  • Upgrade detekt plugin
  • Upgrade spotless plugin
  • Fix Detekt configuration

Downstream Consumer Impact

Need to test with major projects using plugin to ensure pipelines still work.

How Has This Been Tested?

Publishing and testing with Path internal and external projects on Java 8 and Java 17

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mattnichols mattnichols marked this pull request as draft September 20, 2022 19:37
@mattnichols mattnichols force-pushed the cleanup_pmd_rules branch 3 times, most recently from 5efa3b9 to 44de0f7 Compare September 21, 2022 01:35
@mattnichols mattnichols marked this pull request as ready for review September 21, 2022 02:36
@NateIorgMX
Copy link
Contributor

I'll pull this into a few projects and test Java 8.

NateIorgMX
NateIorgMX reviewed Sep 21, 2022
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
stevecl5
stevecl5 reviewed Sep 21, 2022
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@mattnichols
Copy link
Collaborator Author

I'll pull this into a few projects and test Java 8.

I pulled it into several projects (java 8 and 17). They all worked.

@NateIorgMX
Copy link
Contributor

I'll pull this into a few projects and test Java 8.

I pulled it into several projects (java 8 and 17). They all worked.

Ah, I misunderstood the Downstream Consumer Impact section.

@mattnichols
Update configurations and dependencies
dd89ca9 
* Remove deprecated PMD rules
* Add Hush plugin
* Upgrade detekt plugin
* Fix Detekt configuration
@mattnichols mattnichols merged commit 883d853 into master Sep 21, 2022
@mattnichols mattnichols deleted the cleanup_pmd_rules branch September 21, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NateIorgMX NateIorgMX NateIorgMX approved these changes

@stevecl5 stevecl5 stevecl5 approved these changes

@SandhyaBhatia SandhyaBhatia Awaiting requested review from SandhyaBhatia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattnichols @NateIorgMX @stevecl5