remove import of devtools in test_collection #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +63,6 @@ def __init__(self, view, data_model: TestCollectionQueueModel): | |||
|
|
|||
| def execute(self): | |||
| super().execute() | |||
| debug(self._data_model._task_data) | |||
There was a problem hiding this comment.
Oh, yes. debug is on the other hand quite handy so we should probably add that dependency. We can do that in another PR though, because I understand that this would break as it is.
Don't import devtools module for the test collection queue entry. Mxcube-core does not list devtools package as a dependency. Also remove unused import of HardwareRepository.
marcus-oscarsson
force-pushed
the
drop-debug-import
branch
from
9c181d7
to
452d8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't import
devtoolsmodule for the test collection queue entry. Mxcube-core does not list devtools package as a dependency.Also remove unused import of HardwareRepository.