Deprecating Device and Equipment #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not know much about making deprecations. This page says we should put one in |
|
I guess its in-case the subclass does not call |
marcus-oscarsson
force-pushed
the
mo-deprecating-device
branch
from
fb1b16c
to
4ba7c36
Compare
rhfogh
approved these changes
Aug 1, 2024
The warning only prints the text. It does not raise any exception and does not stop the execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DeviceandEquipmentclasses are still in the code base but now with a deprecation warning. There are still a few more objects that use Device and Equipment to look at. Please have a look at your site specific and local code, let me know and make the necessary changes. I will follow up with a PR that removesEquipmentandDevice