-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to solve issue 902 #940
Conversation
Missing some words here? :D |
I'm not sure this is the best way to do this; I would suggest that each site goes through their specific files and the common files to check if the proposed changes are alright. Or we can open a PR per site and for common files if its more digestible ? |
Its the |
There are two aspects of this issue - one is to change everywhere in the python code Device and Equipment inheritance and remove the two classes.The other is to change all the device and equipment to object keyword in the xml files. |
So what do you think, are we ready to make the jump to |
5a8de49
to
e9e98c3
Compare
No regrets :) |
Attempt to resolve #902. If accepted everybody have to update their local configuration files and use
<object>
instead of<equipment>
or<device>
#issue 902