-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V7 merge #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add guarantee sequence utils
Add AnyPromise.wait
Xcode 11 / Swift 5.1 support
correcting and aligning documentation regarding `resolve` and `fulfil…
Cannot push to CoreBluetooth since I archived it
[ci] Xcode 10.2 -> 10.3
* Promise.value when T == Void * Guarantee.value where T == Void * Replace class with static because Promise is final * Optimised Guarantee.value where Value == Void * Add comment * Implementation with Void() * Tests for Promise<Void>.value * Tests for Guarantee<Void>.value * Added tests for Promise<Void> and Guarantee<Void>
Swift 5.1 release travis linux
refactor(*): Change empty tuples to `Void`
Provide a simpler exlanation and examples about when promises "start". Make it clear that the promise's body executes after the promise is created, without the need to call `then` or `done` on it. Also clarify that async tasks that a being kicked off from a promise's body behave the same way regardless of whether PromiseKit is being used or not.
We need full CI for all PRs sadly
Doing tests for all versions as some of the NSError stuff we do is flakey on various Swift versions.
[ci] Linux code coverage (& test all Linux Swift)
Fixed isCancelled crash
[ci] test in parallel
79ce641
to
afaee49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.