CancellablePromise bridge initializer should run 'catch' on CurrentThreadDispatcher() #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iseKit should perhaps not be doing The cancellable promise bridge now runs 'catch' on the current thread dispatcher. Updated tests for the change.
|
Looks awesome, Doug - thanks for taking a look at this! |
|
There's a 7.0.0-alpha3 tag at the previous head which I didn't move or supersede. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1049: "Some tests seem to depend on dispatching that PromiseKit should perhaps not be doing"
Yup, CancellablePromise is definitely doing some dispatching that it shouldn't be doing. Fixed exactly as Garth suggests, by having the CancellablePromise bridge initializer run 'catch' on CurrentThreadDispatcher().
Also updating 6 affected tests for this change.