Dispatchers cleanup #1022
Merged
Dispatchers cleanup #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarthSnyder
force-pushed
the
dispatcher-cleanup
branch
from
a9dbc3d to
4c7b721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small things:
I noticed some incorrect access levels when using this from a client project, so I went back and did an access level review.
Added DispatchQueue wrappers for Dispatcher implementations, so you can now say, e.g.
Added tests for those wrappers
Moved Dispatcher implementations to a subdirectory
The compiler started complaining about
Sequence.count(where:)in Xcode 10.2 beta 4. I'm not sure why. Rewrote.