Skip to content

fix(server): Stop re-probing hosting CLIs for unrecognized hosts - #41

Draft
mwolson wants to merge 1 commit into
personal/clerk-token-file-modefrom
personal/unknown-host-refinement-storm
Draft

mwolson wants to merge 1 commit into
personal/clerk-token-file-modefrom
personal/unknown-host-refinement-storm

Conversation

@mwolson

@mwolson mwolson commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

What Changed

This carries pingdotgg#19692 unknown-host-refinement-cache, Mike's smaller fix for pingdotgg#12060 unknown-host-refinement-storm, opened after pingdotgg#12071 unknown-host-refinement-storm and pingdotgg#18270 cache-host-verdicts were closed unmerged. Both earlier authors are co-authors on the commit.

For a remote on a host T3 Code does not recognize, the server remembers which hosting integration claims it, including "none", for five minutes, and checkouts on the same server and path prefix share one lookup. A missing CLI, a missing GitHub login, or glab reporting no login for that host counts as an answer. Timeouts, API or keyring failures, and failures in one checkout are not remembered. glab is asked about the remote's own host, and a Settings change clears the cache.

Why

Several projects on one unrecognized host made the pull request sweep re-run glab, fj, tea and the GitHub credential lookup for every checkout on every read. That slows sidebar status, can show "Reconnecting", and on macOS can exhaust Gatekeeper. This layer is dropped when pingdotgg#19692 unknown-host-refinement-cache merges upstream.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@mwolson
mwolson added this pull request to stack #38 September 30, 2026 12:59
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 7a36296 to 3531260 Compare September 30, 2026 20:01
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 3531260 to 68fa363 Compare October 1, 2026 12:38
@mwolson
mwolson removed this pull request from stack #38 October 1, 2026 12:39
@mwolson
mwolson changed the base branch from personal/provider-log-thread-files to personal/wsl-busy-runtime-fixture October 1, 2026 12:40
@mwolson
mwolson added this pull request to stack #54 October 1, 2026 12:41
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 68fa363 to 9beb9ba Compare October 1, 2026 14:13
@mwolson
mwolson removed this pull request from stack #54 October 1, 2026 14:13
@mwolson
mwolson changed the base branch from personal/wsl-busy-runtime-fixture to personal/clerk-token-file-mode October 1, 2026 14:13
@mwolson
mwolson added this pull request to stack #56 October 1, 2026 14:13
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 9beb9ba to 5f8ce88 Compare October 3, 2026 20:27
@mwolson
mwolson removed this pull request from stack #56 October 3, 2026 20:28
@mwolson
mwolson added this pull request to stack #57 October 3, 2026 20:28
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 5f8ce88 to 4818143 Compare October 4, 2026 03:12
@mwolson
mwolson removed this pull request from stack #57 October 4, 2026 03:12
@mwolson
mwolson added this pull request to stack #60 October 4, 2026 03:13
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 4818143 to 1bd0ce3 Compare October 4, 2026 15:11
@mwolson
mwolson removed this pull request from stack #60 October 4, 2026 15:12
@mwolson
mwolson added this pull request to stack #62 October 4, 2026 15:12
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 1bd0ce3 to 86f89f1 Compare October 4, 2026 19:29
@mwolson
mwolson removed this pull request from stack #62 October 4, 2026 19:29
@mwolson
mwolson added this pull request to stack #64 October 4, 2026 19:30
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 86f89f1 to 30e58e3 Compare October 6, 2026 17:48
@mwolson
mwolson removed this pull request from stack #64 October 6, 2026 17:49
@mwolson
mwolson added this pull request to stack #74 October 6, 2026 22:10
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 76a708b to 2812962 Compare October 6, 2026 22:19
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 2812962 to 3154a84 Compare October 6, 2026 22:58
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 3154a84 to 3798e5a Compare October 6, 2026 23:17
@mwolson
mwolson removed this pull request from stack #74 October 10, 2026 02:40
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 3798e5a to d33f376 Compare October 10, 2026 02:41
@mwolson
mwolson added this pull request to stack #77 October 10, 2026 02:41
@mwolson
mwolson removed this pull request from stack #77 October 10, 2026 15:52
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from d33f376 to f875548 Compare October 10, 2026 15:52
@mwolson
mwolson added this pull request to stack #81 October 10, 2026 15:53
@mwolson
mwolson removed this pull request from stack #81 October 10, 2026 16:45
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from f875548 to 9a8ef9c Compare October 10, 2026 16:45
@mwolson
mwolson added this pull request to stack #84 October 10, 2026 16:45
@mwolson
mwolson removed this pull request from stack #84 October 15, 2026 01:56
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 9a8ef9c to 33eb18f Compare October 15, 2026 01:56
@mwolson
mwolson added this pull request to stack #85 October 15, 2026 01:56
@mwolson mwolson changed the title fix(server): Stop re-probing hosting CLIs for unrecognised remotes fix(server): Stop re-probing hosting CLIs for unrecognized hosts Oct 15, 2026
@mwolson
mwolson removed this pull request from stack #85 October 15, 2026 07:04
@mwolson
mwolson force-pushed the personal/unknown-host-refinement-storm branch from 33eb18f to 17f128a Compare October 15, 2026 07:04
@mwolson
mwolson added this pull request to stack #87 October 15, 2026 07:04
Remember the unknown-remote refinement verdict for five minutes, shared by
checkouts whose remotes have the same server and path prefix. Callers that
arrive while a probe runs wait on it. A missing CLI, a missing GitHub login,
or glab reporting no login for the host counts as an answer. A timeout, an
API or keyring failure, or a claim reached after an earlier check failed is
not cached. glab is asked about the remote's own host, spelled as the remote
spells it, and a Settings change clears the cache.

Fixes pingdotgg#12060

Carries pingdotgg#19692 unknown-host-refinement-cache for the
Nightly. Drop this layer at the refresh after pingdotgg#19692 merges upstream.

Co-authored-by: Victor Vogel <263261067+only21mil@users.noreply.github.com>
Co-authored-by: Jorrin <43169049+JorrinKievit@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant