Skip to content

fix: validatorWithNonRepeatedConstraint cannot detect repeated constraint #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: validatorWithNonRepeatedConstraint cannot detect repeated constraint #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions plugin/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ package plugin
import (
"fmt"
"os"
"reflect"
"strconv"
"strings"

Expand Down Expand Up @@ -664,22 +663,8 @@ func (p *plugin) validatorWithNonRepeatedConstraint(fv *validator.FieldValidator
return false
}

// Need to use reflection in order to be future-proof for new types of constraints.
v := reflect.ValueOf(*fv)
for i := 0; i < v.NumField(); i++ {
fieldName := v.Type().Field(i).Name

// All known validators will have a pointer type and we should skip any fields
// that are not pointers (i.e unknown fields, etc) as well as 'nil' pointers that
// don't lead to anything.
if v.Type().Field(i).Type.Kind() != reflect.Ptr || v.Field(i).IsNil() {
continue
}

// Identify non-repeated constraints based on their name.
if fieldName != "RepeatedCountMin" && fieldName != "RepeatedCountMax" {
return true
}
if fv.RepeatedCountMin == nil && fv.RepeatedCountMax == nil {
return true
}
return false
}
Expand Down