Support Go modules #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
force-pushed
the
support-go-modules
branch
2 times, most recently
from
2230cb4 to
c491c22
Compare
simonpasquier
commented
Jul 2, 2019
.travis.yml
Outdated
| language: go | ||
| go: | ||
| - 1.7 | ||
| - 1.9 |
There was a problem hiding this comment.
From https://github.com/prometheus/client_golang/#prometheus-go-client-library:
This library requires Go1.9 or later.
simonpasquier
force-pushed
the
support-go-modules
branch
from
c491c22 to
202fee9
Compare
Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
support-go-modules
branch
from
5475a4f to
ea44f44
Compare
|
@mwitkow friendly ping |
|
ping @mwitkow ptal 🤗 |
AlekSi
reviewed
Mar 6, 2020
| - "1.9.x" | ||
| - "1.10.x" | ||
| - "1.11.x" | ||
| - "1.12.x" |
There was a problem hiding this comment.
There is no need to use quotes if you add .x. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4
github.com/prometheus/common(and many of the other Prometheus projects) depends on this library and already support Go modules. It would be nice to have for us...