refactor: extract collection predicate binding to its own language construct #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymc9
commented
Jan 15, 2026
ymc9
commented
- Adjusted language processing chain accordingly
- Fixed several issues in policy transformer/evaluator
- More test cases
…nstruct - adjusted language processing chain accordingly - fixed several issues in policy transformer/evaluator - more test cases
mwillbanks
approved these changes
Jan 16, 2026
Owner
mwillbanks
left a comment
mwillbanks
left a comment
There was a problem hiding this comment.
wow... that was quite the refactor, quite nice to read through... now as i've continued to understand a lot more of the core of zenstack it makes a ton more sense why you did it this way as well. the refactoring of the bindings is extremely nice and can't wait to start utilizing it.
mwillbanks
merged commit bac5e6b
into
mwillbanks:feat/audit-collection-aliases
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.