discourse: 3.1.0 -> 3.2.1 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distutils module is deprecated and was removed in Python 3.12, which would eventually break this updater.
The plugin updater would previously stumble over compat spec version entries that begin with angled brackets. ```` < 3.3.0.beta1-dev: 56b0de3896361b6a87523537c8f5b450d2fe0807 3.2.0: 33c43ca51ac7b7baa8a309a269dcf8685b8bd638 < 3.2.0.beta2-dev: ac930c509e2a5b0c37b84bcea28d332e686add95 3.1.999: a304cd2028ccf1f5b00f5137633aa7027a1fd334 3.1.0.beta3: 9c270cac9abc1c2b30574d8c655fb3a90546236b [...] ````
fix installation of yarn dependencies
|
The errors you encountered stemmed from a little oversight. The yarn.lock treated with |
mweinelt
force-pushed
the
discourse-update
branch
from
8f26e12
to
e50869e
Compare
|
Thanks, squashed into the update commit on the target branch. |
|
Link: NixOS#299269 |
mweinelt
pushed a commit
that referenced
this pull request
Jul 31, 2024
This adds some extremely helpful and popular encoders in by default: * openjpeg * celt * libwebp * libaom On the `master` branch, closure size for ffmpeg-headless went up 18.5 MiB. ``` $ nix store diff-closures nixpkgs#ffmpeg-headless^bin .#ffmpeg-headless^bin celt: ∅ → 0.11.3, +168.4 KiB ffmpeg-headless: +70.0 KiB giflib: ∅ → 5.2.2, +398.7 KiB lcms2: ∅ → 2.16, +466.2 KiB lerc: ∅ → 4.0.0, +840.2 KiB libaom: ∅ → 3.9.0, +8047.8 KiB libdeflate: ∅ → 1.20, +427.0 KiB libtiff: ∅ → 4.6.0, +655.9 KiB libvmaf: ∅ → 3.0.0, +2665.0 KiB libwebp: ∅ → 1.4.0, +2559.7 KiB openjpeg: ∅ → 2.5.2, +1525.1 KiB zstd: ∅ → 1.5.6, +1158.0 KiB $ nvd diff $(nix build nixpkgs#ffmpeg-headless^bin --print-out-paths --no-link) $(nix build .#ffmpeg-headless^bin --print-out-paths --no-link) <<< /nix/store/4n60lnj3zkjpasd4c56bzhpx2m8lc1sx-ffmpeg-headless-6.1.1-bin >>> /nix/store/884f487w5hac6rs94jq6hq5zqkxdv666-ffmpeg-headless-6.1.1-bin Added packages: [A.] #1 celt 0.11.3 [A.] #2 giflib 5.2.2 [A.] #3 lcms2 2.16 [A.] #4 lerc 4.0.0 [A.] #5 libaom 3.9.0 [A.] #6 libdeflate 1.20 [A.] #7 libtiff 4.6.0 [A.] #8 libvmaf 3.0.0 [A.] #9 libwebp 1.4.0 x2 [A.] #10 openjpeg 2.5.2 [A.] NixOS#11 zstd 1.5.6 Closure size: 66 -> 78 (15 paths added, 3 paths removed, delta +12, disk usage +18.5MiB). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix installation of yarn dependencies. Discourse is moving the dependencies towards the root yarn.lock.
Currently in version 3.2.x the root yarn.lock does not replace app/assets/javascripts/yarn.lock but only holds the required devDependencies for building theme-transpiler.js which will be run as a dependent task of db:migrate when starting the service.
In the next minor version 3.3.x the workspace list will move into the root yarn.lock (meaning dependencies will be installed in the root node_modules) and the app/assets/javascripts/yarn.lock will be removed, therefore the $yarnDevOfflineCache was not added to update.py.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)