Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR: Revert recent refactoring #5

Closed
wants to merge 1 commit into from

Conversation

mweberxyz
Copy link
Owner

This PR simply reverts the recent refactoring PR - do not merge.

Benchmark tag added to show the performance regression that would be caused by merging this revert.

Copy link

Benchmark Node 18 PR Node 18 Base Node 20 PR Node 20 Base Node 21 PR Node 21 Base
express.js 7919 7998 8610 8729 7929 7948
fastify.js 26344 39921 31299 42120 30932 41153
fastify-art.js 8623 9034 10430 10759 8031 8626
fastify-dot.js 32734 44406 35070 46300 34228 46232
fastify-eta.js 23586 26091 26929 29249 32638 35864
fastify-pug.js 21906 37437 32119 39264 24689 37653
fastify-twig.js 21288 31950 28408 35774 26802 35819
fastify-liquid.js 5820 6456 6746 7458 6525 7438
fastify-mustache.js 23589 30073 30428 33390 29580 33534
fastify-nunjucks.js 31462 39560 34564 41076 33582 41006
fastify-ejs-async.js 31400 38856 35195 41976 34145 41582
fastify-ejs-minify.js 8988 11522 11094 14426 10649 13256
fastify-handlebars.js 20079 22634 25605 29697 24911 25218
fastify-ejs-local-layout.js 18016 24876 21690 30312 21949 29371
fastify-ejs-global-layout.js 25346 35422 28532 39336 28063 38225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant