Skip to content

Suggestions for PR https://github.com/NCAR/ccpp-framework/pull/612#1

Merged
mwaxmonsky merged 1 commit into
mwaxmonsky:testing-refactorfrom
climbfuji:feature/refactor_feedback_dom
Jul 11, 2025
Merged

Suggestions for PR https://github.com/NCAR/ccpp-framework/pull/612#1
mwaxmonsky merged 1 commit into
mwaxmonsky:testing-refactorfrom
climbfuji:feature/refactor_feedback_dom

Conversation

@climbfuji
Copy link
Copy Markdown

Suggestions to clean up OpenMP cmake integration and cmake diagnostic output (for PR NCAR#612)

@climbfuji climbfuji requested a review from mwaxmonsky as a code owner July 11, 2025 22:02
Comment thread .gitignore
*.pyc

# CMake build directory
build/ No newline at end of file
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build/
build/

Copy link
Copy Markdown
Owner

@mwaxmonsky mwaxmonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @climbfuji! Looks great!

@mwaxmonsky mwaxmonsky merged commit 3013128 into mwaxmonsky:testing-refactor Jul 11, 2025
5 checks passed
@climbfuji climbfuji deleted the feature/refactor_feedback_dom branch July 11, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants