Conversation
otiv-milan
force-pushed
the
feature/ros2_rust_logging
branch
from
952d53e to
d662d91
Compare
mvukov
approved these changes
Sep 8, 2024
trad0v
pushed a commit
to EddyGharib/rules_ros2
that referenced
this pull request
Oct 2, 2024
parth-emancro
pushed a commit
to emancro/rules_ros2
that referenced
this pull request
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logging to ros2_rust. Since rcl_bindings is private to rlcrs I had to inject logging.rs to rclrs build. The logging functionality should eventually live in ros2_rust repo.