bib: add support for --type bootc-installer

This commit adds support for the new `bootc-installer` image
type that will take a bootc container and create an ISO out
of it. It also adds a new `--installer-payload-ref` option
so that the user can specify a different payload container
to install.

See osbuild/images#1906 for details.

This is the equivalent of
osbuild#341
for bootc-image-builder and allows us to build these kinds
of images with bib now too.

Author: mvo5

bib/internal/imagetypes/imagetypes.go

@@ -17,13 +17,14 @@ var supportedImageTypes = map[string]imageType{
 	// XXX: ideally we would look how to consolidate all
 	// knownledge about disk based image types into the images
 	// library
-	"ami":   imageType{Export: "image"},
-	"qcow2": imageType{Export: "qcow2"},
-	"raw":   imageType{Export: "image"},
-	"vmdk":  imageType{Export: "vmdk"},
-	"vhd":   imageType{Export: "vpc"},
-	"gce":   imageType{Export: "gce"},
-	"ova":   imageType{Export: "archive"},
+	"ami":             imageType{Export: "image"},
+	"qcow2":           imageType{Export: "qcow2"},
+	"raw":             imageType{Export: "image"},
+	"vmdk":            imageType{Export: "vmdk"},
+	"vhd":             imageType{Export: "vpc"},
+	"gce":             imageType{Export: "gce"},
+	"ova":             imageType{Export: "archive"},
+	"bootc-installer": imageType{Export: "bootiso", ISO: true},
 	// the iso image types are RPM based and legacy/deprecated
 	"anaconda-iso": imageType{Export: "bootiso", ISO: true, Legacy: true},
 	"iso":          imageType{Export: "bootiso", ISO: true, Legacy: true},

bib/internal/imagetypes/imagetypes_test.go

@@ -57,21 +57,25 @@ func TestImageTypes(t *testing.T) {
 			imageTypes:  []string{"vmdk", "anaconda-iso"},
 			expectedErr: errors.New("cannot mix ISO/disk images in request [vmdk anaconda-iso]"),
 		},
-		"bad-mix-part-2": {
+		"bad-mix-2": {
+			imageTypes:  []string{"vmdk", "bootc-installer"},
+			expectedErr: errors.New("cannot mix ISO/disk images in request [vmdk bootc-installer]"),
+		},
+		"bad-mix-3": {
 			imageTypes:  []string{"ami", "iso"},
 			expectedErr: errors.New("cannot mix ISO/disk images in request [ami iso]"),
 		},
 		"bad-image-type": {
 			imageTypes:  []string{"bad"},
-			expectedErr: errors.New(`unsupported image type "bad", valid types are ami, anaconda-iso, gce, iso, ova, qcow2, raw, vhd, vmdk`),
+			expectedErr: errors.New(`unsupported image type "bad", valid types are ami, anaconda-iso, bootc-installer, gce, iso, ova, qcow2, raw, vhd, vmdk`),
 		},
 		"bad-in-good": {
 			imageTypes:  []string{"ami", "raw", "vmdk", "qcow2", "something-else-what-is-this"},
-			expectedErr: errors.New(`unsupported image type "something-else-what-is-this", valid types are ami, anaconda-iso, gce, iso, ova, qcow2, raw, vhd, vmdk`),
+			expectedErr: errors.New(`unsupported image type "something-else-what-is-this", valid types are ami, anaconda-iso, bootc-installer, gce, iso, ova, qcow2, raw, vhd, vmdk`),
 		},
 		"all-bad": {
 			imageTypes:  []string{"bad1", "bad2", "bad3", "bad4", "bad5", "bad42"},
-			expectedErr: errors.New(`unsupported image type "bad1", valid types are ami, anaconda-iso, gce, iso, ova, qcow2, raw, vhd, vmdk`),
+			expectedErr: errors.New(`unsupported image type "bad1", valid types are ami, anaconda-iso, bootc-installer, gce, iso, ova, qcow2, raw, vhd, vmdk`),
 		},
 	}