syntax: add a Quote func #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
force-pushed
the
syntax-quote
branch
3 times, most recently
from
2e62dc7
to
b169411
Compare
andreynering
approved these changes
Sep 10, 2021
Similar to strconv.Quote, but with shell syntax. See the added godoc for more details. Unlike strconv.Quote, it needs to return a boolean, as not all strings can be represented in shell. With an example to show and test the basics, as well as a fuzz function to verify edge cases. Fixes #328.
|
Thanks for the review! I extended the fuzz func a bit, and it's now incapable of finding cases that we don't handle. In the process I also taught Quote to avoid issues with comments and assignments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)