format: add nolint to rxCommentDirective #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Jul 9, 2020
Owner
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Sure. Unfortunate that they chose yet another non-standard directive format, though, instead of the standard go:whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofumpt has been added to golangci-lint as of v1.28. Golangci-lint also has a
nolintlintlinter that makes sure the//nolintdirectives don't start with a space. This is conflicting withgofumptthat forces a space to be added.This PR adds
nolinttorxCommentDirectiveto make sure no spaces are added.