Accept strings for xsd base64Binary #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1072 +/- ##
=======================================
Coverage 89.34% 89.35%
=======================================
Files 65 65
Lines 4845 4847 +2
Branches 850 851 +1
=======================================
+ Hits 4329 4331 +2
Misses 333 333
Partials 183 183
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue it would be nice if a value for an element of type xsd:base64Binary could be passed already encoded as string. Since
accepted_types = six.string_typesinBase64BinaryI suggest the same solution as for the mentioned Datetime issue (passing datetime as string).By the way I fixed to missing assert statements.