thmtools and hyperref

[GMS103]

After the last updates, I am getting the errors indicated in
latex3/hyperref#359
I mention it here as I am not sure if it is a hyperref or a thmtools issue.

[u-fischer]

see latex3/hyperref#359 (comment)

[GMS103]

@muzimuzhi
Do you think you could address this 2 things?
TIA
Comment by Ulrike:

As said these are not errors. The info about the bookmark level is not new, I get that also in older texlive. thmtools misses here to define the toc level. This can be done with

\makeatletter
\def\toclevel@The{1} %or some other level
\makeatother

The warning about the destination is new. hyperref no longer (re)defines the \theH<counter> as the kernel handles that. But as thmtools uses a non-standard way to declare "numberwithin" counters it will have to reset \theH<counter> itself. E.g.

\declaretheoremstyle[numberwithin=section]{mytheostyle}
\declaretheorem[name=Theorem,numbered=yes,style=mytheostyle]{The}
\renewcommand\theHThe{\thesection .\arabic {The}}

[muzimuzhi]

Err maybe it's too late to stop recording list of theorems entries (in .loe) by default. 😒

[muzimuzhi]

@u-fischer May I ask what't the recommended time to define \toclevel@<list type>, right when defining a theorem, or delayed to begindocument hook? And do you suggest to not define \toclevel@<list type> if hyperref is not loaded?

[u-fischer]

@muzimuzhi you can define \toclevel@XXX whenever you want and you should do it also if hyperref is not defined (the tagging code makes use of the values, to decide about the level of a toc entry). I would define it at the same time you define the \l@XXX command, then users can reset the level in the preamble if they want.

[rzach]

Just in case someone else finds this because their hyperlinks to theorems are broken now (e.g., links to Thm 2.1 will point to Thm 1.1 as the hyperlink name is just Thm.1 for both): I could work around it by putting

\hypersetup{hypertexnames=false}

in the preamble.