Test for rendering nested partials. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a test for recursive partial nesting but none covering non-recursive.
jgonggrijp
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
I realize this is a rather late review, but I'm in favor of it. 👍
@spullara or @bobthecow, any comments?
|
Makes sense to add a test for this IMHO. |
jgonggrijp
added a commit
that referenced
this pull request
Jan 26, 2024
|
I already tagged the 1.4.0 release, but I'll make another release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming this is expected behavior due to already having a test for recursive partials, and that the ruby implementation handles this behavior (from my limited testing).