Fix #31074: Ensure "don't show again" option is honoured in error dialogs #31110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Nov 19, 2025
cbjeukendrup
force-pushed
the
31074-dont_show_again
branch
from
2cbf5ba to
00520ec
Compare
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #31074
The problem here was that we were creating a new
MScoreErrorsControllerobject every time we wanted to check/show an error. This worked back when the error dialogs were synced but, now that they're async, the controller object goes out of scope before the promise can resolve and callsetNeedToShowMScoreError.This solution makes the controller a private member of
NotationInteraction.