Add item to welcome dialog [4.6.4 port] #31095
Merged
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
force-pushed
the
welcome_dialog_new_item-464
branch
2 times, most recently
from
4c14b4a to
ae744e7
Compare
mathesoncalum
force-pushed
the
welcome_dialog_new_item-464
branch
from
ae744e7 to
ca5f3cf
Compare
Eism
approved these changes
Nov 20, 2025
| item1.insert("buttonText", muse::qtrc("appshell/welcome", "View my scores online")); | ||
| item1.insert("destinationUrl", | ||
| "https://www.youtube.com/watch?v=J2gY9CbMuoI&utm_source=mss-app-yt-4.6-release&utm_medium=mss-app-yt-4.6-release&utm_campaign=mss-app-yt-4.6-release"); | ||
| "https://musescore.com/my-scores?utm_source=mss-app-welcome-musescore-com&utm_medium[…]lcome-musescore-com&utm_campaign=mss-app-welcome-musescore-com"); |
Member
There was a problem hiding this comment.
There's a […] in the middle, is that a copy paste mistake from Slack?
Contributor
Author
There was a problem hiding this comment.
Great catch - yes, from Figma. I'll fix it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports: #31091