Fix Volta layout in palette #31075
Merged
Fix Volta layout in palette #31075
+17
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Nov 17, 2025
Member
|
This does probably not resolve the full issue: the "length" of the spanners in the palette is hardcoded, but apparently stored in DPI-dependent units, so some kind of migration is needed to make palettes from pre-4.7 look good |
mike-spa
force-pushed
the
fixVoltaLayoutInPalette
branch
from
d6f10a4 to
f7aafc8
Compare
| cell->drawStaff = false; | ||
| } | ||
|
|
||
| qreal w = gpaletteScore->style().spatium() * 8; |
This doesn't seem to serve any purpose, it only exists to save the length of SLines in palettes. But that length is irrelevant once the item is inserted in the score (because it's determined by layout), and it's also irrelevant in the Palette, where it should just be set to whatever value allows to draw them properly in the cell.
mike-spa
force-pushed
the
fixVoltaLayoutInPalette
branch
from
f7aafc8 to
ddbdb26
Compare
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30903