Skip to content

FIx close Preferences dialog due to missing negation #31067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2025
+2 −2
Merged

FIx close Preferences dialog due to missing negation #31067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/framework/shortcuts/internal/midiremote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ bool MidiRemote::writeMidiMappings(const MidiMappingList& midiMappings) const

writer.endElement();

return mappingsFile.hasError();
return !mappingsFile.hasError();
}

void MidiRemote::writeMidiMapping(XmlStreamWriter& writer, const MidiControlsMapping& midiMapping) const
Expand Down
2 changes: 1 addition & 1 deletion src/framework/shortcuts/internal/shortcutsregister.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ bool ShortcutsRegister::writeToFile(const ShortcutList& shortcuts, const io::pat

writer.endElement();

return file.hasError();
return !file.hasError();
}

void ShortcutsRegister::writeShortcut(XmlStreamWriter& writer, const Shortcut& shortcut) const
Expand Down
Loading