Import tef fix measure issues

[lvinken]

Resolves: #30806
Resolves: #30807

Fix various forms of corrupted measures resulting from importing common TablEdit files.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[cbjeukendrup]

• Measure has a method fillGap, maybe you can use that, but you do need to add a parameter to make the rests invisible
• If you prefer using a dedicated static function, then you could perhaps still benefit from the toRhythmicDurationList utility, or maybe just toDurationList, both are in durationtype.h.

[lvinken]

I would prefer not to use a dedicated function, but could not find a suitable one ... Note that I do not consider rest visibility important in gaps.

[cbjeukendrup]

It seems this method doesn't really depend on part, so maybe it's also possible to just iterate over all staves of the score in one go, instead of per part?

[lvinken]

Of course.

[lvinken]

Hi Casper, thanks for reviewing. Function Measure::fillGaps() cannot be used as-is, as it is private. I tried to use Measure::checkMeasure) instead which is public. This leads to tuplets failing, which I do not yet understand. Pushed the change anyway to get feedback. Leon.

[cbjeukendrup]

Sorry for not noticing fillGap is private. Perhaps we should then opt for using a dedicated method here. One could argue that Measure::fillGap mainly exists to fix up old corrupted MSCZ files, which might make it not great for reusing in TablEdit import, even while it currently happens to do the same thing.

I notice Measure::check has some logic for skipping tuplets, can the tuplet problems you mention be related to that?

Anyway, let's use a dedicated method again, but perhaps with toRhythmicDurationList to determine which rests are needed.

[lvinken]

Reworked using toDurationList(), as that is somewhat simpler to use. Indeed it seems Measure::check() does not work correctly for truplets.