Skip to content

[MusicXML] add support for encoder #28333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbjeukendrup merged 1 commit into from
Jun 19, 2025
Merged

[MusicXML] add support for encoder #28333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/importexport/musicxml/internal/musicxml/export/exportmusicxml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7068,6 +7068,11 @@ void ExportMusicXml::identification(XmlWriter& xml, Score const* const score)

xml.startElement("encoding");

String encoder = score->metaTag(u"encoder");
if (!encoder.empty()) {
xml.tag("encoder", encoder);
}

if (MScore::debugMode) {
xml.tag("software", String(u"MuseScore 0.7.0"));
xml.tag("encoding-date", String(u"2007-09-10"));
Expand Down
4 changes: 3 additions & 1 deletion src/importexport/musicxml/internal/musicxml/import/importmusicxmlpass1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,9 @@ void MusicXmlParserPass1::identification()
} else if (m_e.name() == "encoding") {
// TODO
while (m_e.readNextStartElement()) {
if (m_e.name() == "software") {
if (m_e.name() == "encoder") {
m_score->setMetaTag(u"encoder", m_e.readText());
} else if (m_e.name() == "software") {
String exporterString = m_e.readText().toLower();
setExporterSoftware(exporterString);
} else if (m_e.name() == "supports" && m_e.asciiAttribute("element") == "beam" && m_e.asciiAttribute("type") == "yes") {
Expand Down
2 changes: 1 addition & 1 deletion src/importexport/musicxml/tests/data/testOrnaments.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<work-title>Ornaments import test</work-title>
</work>
<identification>
<creator type="composer">Klaus Rettinghaus</creator>
<encoding>
<encoder>Klaus Rettinghaus</encoder>
<software>MuseScore 0.7.0</software>
<encoding-date>2007-09-10</encoding-date>
<supports element="accidental" type="yes"/>
Expand Down
1 change: 1 addition & 0 deletions src/importexport/musicxml/tests/data/testSibOttavas_ref.mscx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
<metaTag name="arranger"></metaTag>
<metaTag name="composer"></metaTag>
<metaTag name="copyright"></metaTag>
<metaTag name="encoder">James Mizen</metaTag>
<metaTag name="lyricist"></metaTag>
<metaTag name="movementNumber"></metaTag>
<metaTag name="movementTitle"></metaTag>
Expand Down
Loading