Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17207: Alt+F4 to close a dialog should not activate the top menu #26147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krasko78
Copy link
Contributor

Resolves: #17207

The main menu is activated on the release of the Alt key when m_needActivateHighlight is true. m_needActivateHighlight should become true only when the Alt key is previously pressed alone and not in any other case. On the other hand, it should be set to false as soon as a menu is highlighted, navigation started, another key is pressed and when the menu is closed.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When triggering Alt+F4 to close dialog window, it activates File/Top menu navigating (Windows)
2 participants