Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system locks on remove measures #26136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mike-spa
Copy link
Contributor

Resolves: #25808

@mike-spa mike-spa requested a review from oktophonie January 17, 2025 14:27
@oktophonie oktophonie requested a review from avvvvve January 20, 2025 06:40
@mike-spa mike-spa force-pushed the fixSystemLockOnRemoveMeasures branch from b9eb4d6 to 8e17d49 Compare January 20, 2025 15:51
@mike-spa
Copy link
Contributor Author

Fix the additional issues related to mmRest described here #25808 (comment). Needs retesting @oktophonie @avvvvve

@Jojo-Schmitz

This comment was marked as outdated.

@Jojo-Schmitz

This comment was marked as outdated.

@mike-spa mike-spa force-pushed the fixSystemLockOnRemoveMeasures branch from 8e17d49 to 6969105 Compare January 21, 2025 10:08
@avvvvve
Copy link

avvvvve commented Jan 24, 2025

@mike-spa The delete issue is fixed, but I found some more weirdness with MM rests:

  1. Add some system locks so there are full systems of only rests (in the video, 3 total)
  2. Turn on MM rests, and system locks are ignored favoring collapsing all empty measures together (not sure if this is the desired behavior or not)
  3. Turn them off again (NOT via undo), and you get a state similar to the issue you last linked where too many measures are on one system
  4. Then, undo twice, and I get an extra system lock where there wasn't one before (ended up with 4)
system-locks-mmrests.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Nightly) Deleting a measure with a system lock breaks things
4 participants