Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move top system objects when rearranging staves #26134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mike-spa
Copy link
Contributor

Resolves: #25822

This has always been quite a buggy and confusing area of code. The general principle (as far as I understand) is that the "top" system object should not move when rearranging staves (cause it should just stay at the top of the score), whereas "non-top" system objects follow their stave, which makes sense.
But I've never understood why the condition of being top system object should be deduced from the linking properties. The fact that top and non-top system objects are linked to each other is a consequence, not a definition. Furthermore, linking has the additional complexity that links can exists within the same score, but also across score and parts (hence why this bug showed up in parts but not in the main score).

It seems quite clear to me that being a "top" system object should just mean being a system object at the top of the score (i.e. at track == 0). If it turns up that other parts of code relied on the previuos strange definition (which is likely), we'll fix those too.

@mike-spa mike-spa requested a review from oktophonie January 17, 2025 12:57
@oktophonie oktophonie requested a review from miiizen January 20, 2025 13:11
@miiizen miiizen self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempi, Staff text and Rehearsal marks not correctly displayed when instrument order changed in parts
3 participants