Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tini to Docker image #657

Merged
merged 2 commits into from
May 15, 2022

Conversation

rblaine95
Copy link
Contributor

  • I updated the changelog

@rblaine95 rblaine95 changed the title feat: Add tini feat: Add tini to Docker image May 15, 2022
@github-actions
Copy link

github-actions bot commented May 15, 2022

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-657 or codetheweb/muse:d9df816e2d377d86d9ae4caefdccbbce6e79289f.

Images are available for x86_64 and ARM64.

Latest commit: d9df816

@codetheweb
Copy link
Collaborator

Thanks for the contributions!

I don't think this is necessary though, is Muse creating zombie processes?

@rblaine95
Copy link
Contributor Author

rblaine95 commented May 15, 2022 via email

@rblaine95
Copy link
Contributor Author

The zombie process issue is resolved with tini
image

rblaine95 added 2 commits May 15, 2022 20:54
* Add tini to reap zombie processes
* krallin/tini#8
@rblaine95 rblaine95 force-pushed the feat/add-tini-docker branch from 1af5ada to d9df816 Compare May 15, 2022 18:54
@codetheweb codetheweb merged commit cb11398 into museofficial:master May 15, 2022
@github-actions
Copy link

🚀 Released in Release v2.0.3.

@rblaine95 rblaine95 deleted the feat/add-tini-docker branch May 15, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants