-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only one kernel at run-time, #156
Merged
ossama-othman
merged 23 commits into
multipath-tcp:master
from
ossama-othman:user-pm-cmds
Jan 11, 2022
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ae80e95
include: Add missing forward declarations.
1d5a3d1
include: Add missing Doxygen documentation.
d93c215
src: Refactor user space PM commands.
45d5918
src: Add user space PM commands for upstream.
794c44f
src: Minor documentation tweak.
a2ad52a
configure: Add '--with-kernel' option.
6deab1d
github: Add multipath-tcp.org kernel build.
b029941
configure: Simplify auto kernel selection.
b4ef5b4
Revert "src: Refactor user space PM commands."
6c8f29e
src: Add missing type declarations.
edc5010
src: Drop common netlink PM command implementation.
da44071
github: s/distcheck/check/g for mptcp.org build.
51caadc
src: Return ENOTSUP not -ENOTSUP in stubs.
47815a1
github: Do not run checks for multipath-tcp.org kernel.
48dc868
include: Add proposed <linux/mptcp.h> updates.
379dc07
configure: Define HAVE_UPSTREAM_KERNEL as needed.
b6afabe
configure: Log which kernel will be used.
692be2f
configure: Refactor <linux/mptcp.h> header checks.
ec5da73
include: Drop removed preprocessor symbol.
9199bc7
src: Only call dump_addrs for upstream kernel.
b25666f
src: Fix code that broke during rebase.
af3236d
github: Build and install ELL 0.30.
7816575
src: Remove duplicate get_port_number() code.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: multipath-tcp.org kernel | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: dependencies | ||
run: sudo apt-get -y install autoconf-archive git | ||
- name: build and install ELL | ||
run: | | ||
git clone git://git.kernel.org/pub/scm/libs/ell/ell.git | ||
cd ell | ||
git checkout 0.30 | ||
./bootstrap | ||
./configure --prefix=/usr | ||
sudo make install | ||
- name: bootstrap | ||
run: ./bootstrap | ||
- name: configure | ||
run: ./configure --with-kernel=multipath-tcp.org | ||
- name: make | ||
run: make |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,8 @@ enum { | |
MPTCP_PM_ATTR_ADDR, /* nested address */ | ||
MPTCP_PM_ATTR_RCV_ADD_ADDRS, /* u32 */ | ||
MPTCP_PM_ATTR_SUBFLOWS, /* u32 */ | ||
MPTCP_PM_ATTR_TOKEN, /* u32 */ | ||
MPTCP_PM_ATTR_LOC_ID, /* u8 */ | ||
|
||
__MPTCP_PM_ATTR_MAX | ||
}; | ||
|
@@ -84,6 +86,8 @@ enum { | |
MPTCP_PM_CMD_SET_LIMITS, | ||
MPTCP_PM_CMD_GET_LIMITS, | ||
MPTCP_PM_CMD_SET_FLAGS, | ||
MPTCP_PM_CMD_ANNOUNCE, | ||
MPTCP_PM_CMD_REMOVE, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know there's more to the new API than this. More to come in a subsequent pull request. |
||
|
||
__MPTCP_PM_CMD_AFTER_LAST | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# SPDX-License-Identifier: BSD-3-Clause | ||
# | ||
# Copyright (c) 2021, Intel Corporation | ||
|
||
#serial 1 | ||
|
||
# MPTCPD_IF_UPSTREAM_KERNEL([ACTION-IF-TRUE], [ACTION-IF-FALSE]) | ||
# | ||
# Check if the <linux/mptcp.h> header for the upstream kernel is | ||
# available in the system include path. | ||
AC_DEFUN([MPTCPD_IF_UPSTREAM_KERNEL], | ||
[ | ||
AC_CACHE_CHECK([for MPTCP_PM_CMD_ANNOUNCE in linux/mptcp.h], | ||
[mptcpd_cv_header_upstream], | ||
[ | ||
AC_COMPILE_IFELSE([ | ||
AC_LANG_SOURCE([ | ||
#include <linux/mptcp.h> | ||
|
||
int announce_cmd(void) { return MPTCP_PM_CMD_ANNOUNCE; } | ||
]) | ||
], | ||
[mptcpd_cv_header_upstream=yes], | ||
[mptcpd_cv_header_upstream=no]) | ||
]) | ||
|
||
AS_IF([test "x$mptcpd_cv_header_upstream" = xyes], [$1], [$2]) | ||
]) | ||
|
||
# MPTCPD_IF_MPTCP_ORG_KERNEL([ACTION-IF-TRUE], [ACTION-IF-FALSE]) | ||
# | ||
# Check if the <linux/mptcp.h> header for the multipath-tcp.org kernel | ||
# is available in the system include path. | ||
AC_DEFUN([MPTCPD_IF_MPTCP_ORG_KERNEL], | ||
[ | ||
AX_CHECK_DEFINE([linux/mptcp.h], [MPTCP_GENL_NAME], [$1], [$2]) | ||
]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab to space conversion? Wasn't sure if it was intentional, but looks like everything has now been normalized to spaces, so that seems fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spaces were intended. It seems there were left over tabs in this file from previous commits that I missed.