Add garlic32, describe garlic addresses #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we call this "i2p base64 (raw public key)" and "i2p base32 (hashed public key)"? Every time I see "base64" versus "base32" I get confused and re-ask myself why we aren't just using multibase. Then I remember that we're just using the base encodings to distinguish between two very different address formats. |
Contributor
Author
|
No problem. Technically it's just slightly inaccurate in some cases because that's not all the new base32's (for encrypted leasesets: http://www.i2p.net/spec/proposals/149-b32-encrypted-ls2) have, but that is the default and far and away the most common case. Edit: I extended it a bit, hopefully that's an acceptable description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with the other I2P base32 pull requests, it adds i2p base32 addresses and adds descriptions of what the I2P Addresses are to the table.