This repository was archived by the owner on Sep 29, 2025. It is now read-only.
BREAKING: move constants out of main export #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
hugomrdias
approved these changes
Dec 11, 2020
vmx
reviewed
Dec 11, 2020
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
I would say that using the constants is the main purpose of this library, I'd keep them on the top level.
Member
Author
|
Thinking about it, I agree with @vmx so I will close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting all the codecs constants makes the documentation (and the package) very cluttered. Look at this (you can barely find the functions in the docs):
With this, you can access
multicodecs.codecs.YOUR_MARVELOUS_CODEC.License: MIT
Signed-off-by: Henrique Dias [email protected]