-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
|
||
/** | ||
* @param {string|number} nameOrCode | ||
* @returns {Base} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is Base
defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In base.js
, but currently not documented as it is private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, so people get the idea that a Base
is returned, but they have no idea of what a base is. We should document at least what the base includes here, to not confuse people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed for now
Ref ipfs/js-ipfs#615
Preview: https://multiformats.github.io/js-multibase/